Subject: Re: abi/src/wp/ap/win/ap_Win32Frame.cpp rev. 1.55
From: Mike Nordell (tamlin@algonet.se)
Date: Wed Mar 07 2001 - 09:52:09 CST
Paul Rohr wrote:
> Mike,
>
> Could you explain more about the intent of this revision, and how much of
it
> you think should be preserved?
I'll try.
> I'm getting tempted to revert the whole
> thing, but I hate to take such a drastic step if it's not needed.
>
> Here's why I'm tempted.
>
> I've been trying to figure out why our redraws on NT while scrolling are
so
> much worse than they used to be. I used to be able to cleanly do rapid
> keyboard-level scrolling with the up and down arrows. Now it leaves lots
of
> artifacts on my P233 laptop.
Wierd.AFAIK nothing I changed in that file should neither leave artifacts
nor affect scrolling speed. I run a debug binary here and it works just
fine. Have you tried it on that machine before (without changing gfx
driver)? I'm just trying to find out if you have a bad gfx driver or if it's
indeed an AbiWord problem that leaves these artifacts but somehow it doesn't
show up on my machine.
I started a quick perf. analysis, but it turned out to grow. :-) I've put it
in another post.
> The bug is so obnoxious that I figured it must be recent, so I went to the
> bother of downloading recent binaries to isolate the change. I was quite
> surprised to realize that it appeared between 0.7.9 and 0.7.10 -- and
nobody
> noticed enough to complain. :-(
Had I ever seen this behaviour I would have hunted it down.
> Also, it looks like you took out all of Jeff's
> logic to isolate standalone scrollbar widgets, which will be needed as
soon
> as we support multiple view types. (You know those little widgets that go
> next to the bottom scrollbar in other WPs?)
So _that's_ the reason they were stand-alone. I couldn't for my life
understand why someone would have added scrollbars manually to a window. OK,
with this knowledge it's obvious that those changes were bad. I'll see to
it.
/Mike
This archive was generated by hypermail 2b25 : Wed Mar 07 2001 - 09:52:13 CST