Re: commit: Fix border drawing


Subject: Re: commit: Fix border drawing
From: Thomas Fletcher (thomasf@qnx.com)
Date: Sat Mar 24 2001 - 13:01:48 CST


On Fri, 23 Mar 2001, Paul Rohr wrote:

> At 08:29 PM 3/20/01 -0500, Thomas Fletcher wrote:
> >We are overdrawing by one pixel doing the vertical shadow
>
> FYI. There were some issues really early on where some platforms were
> including endpoints in draw calls, and others weren't. This led to weird
> platform-specific drawing glitches until we agreed on a convention -- sadly,
> I don't recall what it was -- and fixed up any differences in the
> appropriate GR_Graphics subclass(es).
>
> Is it possible that you're running across something similar? I'm not sure
> which shadow you're talking about.
>

cvs ann/cvsblame is your friend.

In this case the including/excluding of the end points issue just
made you lucky that it worked out (it would seem that it would
have impled that the end points were excluded if this were the
case). However the code was wrong and always overdrawing by one
pixel, if you see a problem on other platforms then we can
re-visit it, but I don't think that you will.

Thomas



This archive was generated by hypermail 2b25 : Sat Mar 24 2001 - 12:58:53 CST