Re: Patch: Win32 crash fix - withdrawn


Subject: Re: Patch: Win32 crash fix - withdrawn
From: Andrew Dunbar (hippietrail@yahoo.com)
Date: Fri May 18 2001 - 06:40:25 CDT


Mike Nordell wrote:
>
> Andrew Dunbar wrote:
>
> > case EV_EEMR_COMPLETE:
> > - UT_ASSERT(pEM);
> > - invokeKeyboardMethod(pView,pEM,&charData,1);
> > + {
> > + UT_ASSERT(pEM);
> > + UT_UCSChar *ucs = new UT_UCSChar[1];
> > + ucs[0] = charData;
> > + invokeKeyboardMethod(pView,pEM,ucs,1);
> > + delete [] ucs;
> > + }
>
> Why not simply:
>
> UT_UCSChar ucs = charData;
> invokeKeyboardMethod(pView,pEM,&ucs,1);
>
> or if charData already is UT_UCSChar, why not use it directly? Why new'ing
> an *array* of one single UT_UCSChar???

What a fool I am! The old code now works fine. I guess someone
fixed the real bug while I was being silly. The next patch will be a
real, useful, large one - I promise (:

Andrew Dunbar.

-- 
http://linguaphile.sourceforge.net

_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com




This archive was generated by hypermail 2b25 : Sat May 26 2001 - 03:51:04 CDT