Subject: Re: Patch: Win32 Encoding manager implementation
From: Vlad Harchev (hvv@hippo.ru)
Date: Tue May 22 2001 - 13:15:56 CDT
On Wed, 23 May 2001, Andrew Dunbar wrote:
> Vlad Harchev wrote:
> >
> > On Tue, 22 May 2001, Andrew Dunbar wrote:
> >
> > > Here is an attempt at a Windows encoding manager. All the non-unix
> > > platforms have stub encoding managers that always return ISO-8859-1
> > > as the native encoding.
> > >
> > > My code is an adaption of the unix code so you might want to compare
> > > them.
> >
> > It looks everything is fine. The only issue - why this
> > friend class XAP_EncodingManager;
> > is in header file?
>
> Good question. I'm afraid that's something I blindly copied from
> the Unix EncodingManager. Should they both go or just mine?
Good question :)
It seems it was in Unix EncMgr by mistake - try removing it from Windows
one and see whether anything breaks. If it doesn't break anything - it should
be removed from Unix one too IMO.
Best regards,
-Vlad
This archive was generated by hypermail 2b25 : Sat May 26 2001 - 03:51:06 CDT