Subject: Re: Patch: Win32 Encoding manager implementation
From: Andrew Dunbar (hippietrail@yahoo.com)
Date: Wed May 23 2001 - 00:22:04 CDT
Vlad Harchev wrote:
> > > > My code is an adaption of the unix code so you might want to compare
> > > > them.
> > >
> > > It looks everything is fine. The only issue - why this
> > > friend class XAP_EncodingManager;
> > > is in header file?
> >
> > Good question. I'm afraid that's something I blindly copied from
> > the Unix EncodingManager. Should they both go or just mine?
>
> Good question :)
> It seems it was in Unix EncMgr by mistake - try removing it from Windows
> one and see whether anything breaks. If it doesn't break anything - it should
> be removed from Unix one too IMO.
The friend declaration is needed but the design may be questionable.
The derived get_instance() functions are accessing the base class's
_instance member which is private.
Somebody other than me should investigate this (:
Andrew.
-- http://linguaphile.sourceforge.net _________________________________________________________ Do You Yahoo!? Get your free @yahoo.com address at http://mail.yahoo.com
This archive was generated by hypermail 2b25 : Sat May 26 2001 - 03:51:06 CDT