Subject: Re: Patch: Fix for Bug 1164, 2nd try
From: Vlad Harchev (hvv@hippo.ru)
Date: Thu May 24 2001 - 09:32:20 CDT
On Wed, 23 May 2001, ha shao wrote:
> On Tue, May 22, 2001 at 10:18:00PM +0500, hvv@hippo.ru wrote:
> > On Tue, 22 May 2001, ha shao wrote:
> > > Oh the clean up thing should be done inside mbtowc when the actual
> > > conversion is failed.
> >
> > It's done already - please see the /src/af/util/xp/ut_mbtowc.cpp - method
> > UT_Mbtowc::mbtowc (the last one).
> >
>
> Yes and no. It seems the intent for the initialize() RTF importer
> is to also reset iconv when we have no enough input too. But this
> kind of reset is specifically skipped in UT_Mbtowc::mbtowc().
>
> Since the aggregate buffer is maintained by UT_Mbtowc itself, just
> reset like the attached buffer will do. Dom might want to test if
> this solved the iconv related SEGV.
Now I see, thanks for explanation.
Hmm, I just didn't know how iconv should behave on incomplete sequence (I
didn't expect it to screw up the state)..
Thank you for the patch.
Could anybody please commit it?
Best regards,
-Vlad
This archive was generated by hypermail 2b25 : Sat May 26 2001 - 03:51:07 CDT