Subject: tweaked some truncated strings, please test the patch
From: Alan (horkana@tcd.ie)
Date: Thu Sep 13 2001 - 10:03:40 CDT
i have changed some strings in the file xap_Win32Dlg_FileOpenSaveAs.cpp
All Abiword Images -> All Images
All Abiword Documents -> All Documents
i would have expected All Abiword Documents to mean .abw, .awt, .zabw.
If it were "All Microsoft Documents" i would accusse them of arrogance.
I would change it to
All Supported $whatever, but the string already does not fit the
available space in the dialog (on Win9x at least).
This is purely cosmetic and ignores the bigger problem that the
exisiting code is in completely the wrong place. It causes the
illogical option to Save As All Documents. It should only be in the
Open dialog, and should probalby not be win32 specific, it needs to be
abstracted so that it can be localised.
I am unable to compile Abiword (i have not tried in ages and will try
again soon) so the patch needs to tested and checked first.
(i made the patch using cygwin, vim and then diff -c file1 file2 >
file.diff, so there should not be any CR/LF problems this time)
-- Pinky, are you pondering what I'm pondering? I think so, Brain, but scratching just makes it worse.
*** xap_Win32Dlg_FileOpenSaveAs.old Thu Sep 6 10:01:12 2001 --- xap_Win32Dlg_FileOpenSaveAs.cpp Thu Sep 13 14:01:47 2001 *************** *** 131,137 **** // all supported files filter // TODO localize ! sFilter += m_id == XAP_DIALOG_ID_INSERT_PICTURE ? "All AbiWord Image Files" : "All AbiWord Documents"; sFilter += " (" + sAllSuffixes + ")"; sFilter += '\0'; // include the trailing 0 sFilter += sAllSuffixes; --- 131,138 ---- // all supported files filter // TODO localize ! // WARNING: This should not be here. It causes an illogical choice Save As All Documents. ! sFilter += m_id == XAP_DIALOG_ID_INSERT_PICTURE ? "All Image Files" : "All Documents"; sFilter += " (" + sAllSuffixes + ")"; sFilter += '\0'; // include the trailing 0 sFilter += sAllSuffixes;
This archive was generated by hypermail 2b25 : Thu Sep 13 2001 - 10:03:44 CDT