Re: undo broken in 1.0 - abort 1.0.0 announce 1.0.1?

From: Patrick Lam (plam@plam.lcs.mit.edu)
Date: Wed Apr 24 2002 - 00:29:01 EDT

  • Next message: Andrew Dunbar: "Re: bonobo"

    On Tue, Apr 23, 2002 at 11:16:34PM -0400, Patrick Lam wrote:
    > On Wed, Apr 24, 2002 at 12:55:48PM +1000, Martin Sevior wrote:
    > > Hi Folks,
    > > undo is broken in 1.0.0. As noted by a user, undo now is
    > > effectively "revoke". All editing in a session is undone on pressing
    > > undo right now.
    > >
    > > I have uploaded Jeremey's build for 1.0 to sourceforge. It would be great
    > > to have bidi, plugins and spelling modules for windows but it appears
    > > nobody else has time to work on these.
    > >
    > > Do we want to continue with 1.0.0 or abort and do 1.0.1? I'll leave that
    > > up to Dom.
    >
    > Unfortunately, this is probably my fault; I did commit a change to
    > undo behaviour that seemed to work for me. I couldn't reproduce the
    > new undo problem.

    Oops. Repeat count was wrapping around to negative. Fixed by putting
    the repeat count into a signed variable.

    fix crazy undo bug (unsigned vars suck)
    CVS: ----------------------------------------------------------------------
    CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
    CVS:
    CVS: Committing in .
    CVS:
    CVS: Modified Files:
    CVS: src/text/ptbl/xp/pd_Document.cpp
    CVS: ----------------------------------------------------------------------

    pat



    This archive was generated by hypermail 2.1.4 : Wed Apr 24 2002 - 00:33:41 EDT