From: Patrick Lam (plam@plam.lcs.mit.edu)
Date: Tue Apr 23 2002 - 23:16:34 EDT
On Wed, Apr 24, 2002 at 12:55:48PM +1000, Martin Sevior wrote:
> Hi Folks,
> undo is broken in 1.0.0. As noted by a user, undo now is
> effectively "revoke". All editing in a session is undone on pressing
> undo right now.
>
> I have uploaded Jeremey's build for 1.0 to sourceforge. It would be great
> to have bidi, plugins and spelling modules for windows but it appears
> nobody else has time to work on these.
>
> Do we want to continue with 1.0.0 or abort and do 1.0.1? I'll leave that
> up to Dom.
Unfortunately, this is probably my fault; I did commit a change to
undo behaviour that seemed to work for me. I couldn't reproduce the
new undo problem.
Here's the patch in question; I thought it fixed 2511. Could someone
who experiences bad undo behaviour try with current Abi and with this patch
backed out?
Index: src/wp/ap/xp/ap_EditMethods.cpp
===================================================================
RCS file: /cvsroot/abi/src/wp/ap/xp/ap_EditMethods.cpp,v
retrieving revision 1.474
retrieving revision 1.475
diff -r1.474 -r1.475
3838c3838
< pView->delTo(FV_DOCPOS_EOW_SELECT);
---
> pView->delTo(FV_DOCPOS_EOW_MOVE);
Index: src/text/ptbl/xp/pd_Document.cpp
===================================================================
RCS file: /cvsroot/abi/src/text/ptbl/xp/pd_Document.cpp,v
retrieving revision 1.175
retrieving revision 1.176
diff -r1.175 -r1.176
1517c1517,1519
< while (repeatCount--)
---
> while (repeatCount > 0)
> {
> UT_uint32 inCount = undoCount(true);
1519a1522,1523
> repeatCount -= inCount - undoCount(true);
> }
Looking at the patch, it still seems correct to me.
pat
This archive was generated by hypermail 2.1.4 : Tue Apr 23 2002 - 23:18:12 EDT