Subject: Re: commit: Fix lots of stuff.
From: Martin Sevior (msevior@mccubbin.ph.unimelb.edu.au)
Date: Fri Feb 01 2002 - 07:25:02 CST
On Fri, 1 Feb 2002, Hubert Figuiere wrote:
> begin Martin Sevior <msevior@mccubbin.ph.unimelb.edu.au> quotation:
> >
> > I've also included a gzipped patch against previous CVS to help people see
> > what I've changed.
>
> 2 remarks:
>
> *I don't like to see empty implementation in platform code, unless it is done
> by the platform maintainer.
> 2 solutions for that:
> -put an assert
> or
> -don't implement at the risk of breaking the build
> Otherwise it is a real bitch to come up with the new features
OK next time I'll put in asserts.
>
> *I see lot of duplicated code that you put into the platform code. I don't
> like that either. That makes me think I should propose the XP framework
> refactoring (there is bug about that).
> I wish you had a more elegent solution that duplicating....
Me too. Maybe we should have a src/wp/ap/xp/ap_Frame.cpp file. We could
put some of ap_*Frame.cpp in that.
Martin
This archive was generated by hypermail 2b25 : Fri Feb 01 2002 - 07:25:09 CST