commit: 2746

From: Patrick Lam (plam@plam.lcs.mit.edu)
Date: Thu Mar 21 2002 - 15:53:59 EST

Next message: Mike Nordell: "Re: commit: 2746"

Previous message: Michael D. Pritchett: "commit - Win32 Aiksaurus plugin bug"
Next in thread: Mike Nordell: "Re: commit: 2746"
Reply: Mike Nordell: "Re: commit: 2746"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

fix bug 2746 caused by poor parameter naming in pd_Document::_syncFileTypes
CVS: ----------------------------------------------------------------------
CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
CVS:
CVS: Committing in .
CVS:
CVS: Modified Files:
CVS: src/text/ptbl/xp/pd_Document.cpp
CVS: src/text/ptbl/xp/pd_Document.h
CVS: ----------------------------------------------------------------------

Hint: calling variables bOpenedFromSaved is bad and can lead to reversed
if conditions; the fixed code is:

        if (bReadSaveWriteOpen)
          szSuffixes = IE_Exp::suffixesForFileType(m_lastSavedAsType);
        else
          szSuffixes = IE_Imp::suffixesForFileType(m_lastOpenedType);

This makes it clear (at least to me) that this method is to take input
from the m_lastSavedAsType and write its output to m_lastOpenedType.

pat

Next message: Mike Nordell: "Re: commit: 2746"
Previous message: Michael D. Pritchett: "commit - Win32 Aiksaurus plugin bug"
Next in thread: Mike Nordell: "Re: commit: 2746"
Reply: Mike Nordell: "Re: commit: 2746"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

This archive was generated by hypermail 2.1.4 : Thu Mar 21 2002 - 15:54:16 EST