sint/uint mismatches (footnotes, tables)

From: Tomas Frydrych (tomas@frydrych.uklinux.net)
Date: Wed Jan 15 2003 - 07:35:42 EST

  • Next message: Tomas Frydrych: "commit: ev_Toolbar_control.h et al"

    Building AW I have noted a number of uint/sint mismatches in
    comparisons; I do not want to mess up code I am not familiar with or
    to step on anyone's toes, but these should either be dealt with by
    change of type or explicit casts to avoid any hard-to-trace bugs in
    the future.

    FL_DocLayout::getNthFootnote(UT_sint32 i) Can the i passed to this
    function ever be <0? If not, it should probably be changed to uint; as
    it stands the first line of the function's body contains uint/sint
    comparison that should be addressed.

    fp_TableContainer::_size_allocate_pass2(void) row and col, are
    defined as sint, col being in uint/sint mismatch on line 3308.

    fp_TableContainer::sizeRequest(fp_Requisition * pRequisition) sint
    col in uint/sint mismatch on line 3432

    AP_TopRuler::mouseRelease (table-related code) line 2589
    (m_draggingCell ==) 2599, 2616, 2624, 2629, 2634 (i <=, etc.)

    Tomas

    This archive was generated by hypermail 2.1.4 : Wed Jan 15 2003 - 08:15:52 EST