Re: commit: Layout horizontally with screen units.

From: Patrick Lam (plam@plam.lcs.mit.edu)
Date: Fri Jan 24 2003 - 14:24:09 EST

  • Next message: Martin Sevior: "Re: commit: Layout horizontally with screen units."

    remove redundant #ifdefs
    CVS: ----------------------------------------------------------------------
    CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
    CVS:
    CVS: Committing in .
    CVS:
    CVS: Modified Files:
    CVS: src/text/fmt/xp/fb_LineBreaker.cpp
    CVS: ----------------------------------------------------------------------
                                                                                    
    On Fri, Jan 24, 2003 at 09:01:15AM +1100, Martin Sevior wrote:
    > Layout horizontally with screen units. This fixes Justification issues.
    >
    > We definately need to use screen units to layout text horizontally. I see
    > now why we really need Tomas's single units system. Since the width of a
    > text string varies with font size in a way that is not directly
    > proportional to size size.

    While I don't think that we should layout with screen units, I do think
    that your patch was a move in the right direction, because it eliminates
    the use of silly ...InLayoutUnits() functions, so that it's easier to
    move the formatter to actually use layout units everywhere when we
    throw that switch.

    I've committed a removal of the following idiom:

    -#if !defined(WITH_PANGO) && defined(USE_LAYOUT_UNITS)
            UT_ASSERT((UT_sint32)pRunToSplit->getWidth() == splitInfo.iLeftWidth);
    -#else
    - UT_ASSERT((UT_sint32)pRunToSplit->getWidth() == splitInfo.iLeftWidth);
    -#endif

    pat

    This archive was generated by hypermail 2.1.4 : Fri Jan 24 2003 - 14:27:58 EST