From: Martin Sevior (msevior@physics.unimelb.edu.au)
Date: Fri Jan 24 2003 - 14:28:22 EST
On Fri, 24 Jan 2003, Patrick Lam wrote:
> remove redundant #ifdefs
> CVS: ----------------------------------------------------------------------
> CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
> CVS:
> CVS: Committing in .
> CVS:
> CVS: Modified Files:
> CVS: src/text/fmt/xp/fb_LineBreaker.cpp
> CVS: ----------------------------------------------------------------------
>
> On Fri, Jan 24, 2003 at 09:01:15AM +1100, Martin Sevior wrote:
> > Layout horizontally with screen units. This fixes Justification issues.
> >
> > We definately need to use screen units to layout text horizontally. I see
> > now why we really need Tomas's single units system. Since the width of a
> > text string varies with font size in a way that is not directly
> > proportional to size size.
>
> While I don't think that we should layout with screen units, I do think
> that your patch was a move in the right direction, because it eliminates
> the use of silly ...InLayoutUnits() functions, so that it's easier to
> move the formatter to actually use layout units everywhere when we
> throw that switch.
>
> I've committed a removal of the following idiom:
>
> -#if !defined(WITH_PANGO) && defined(USE_LAYOUT_UNITS)
> UT_ASSERT((UT_sint32)pRunToSplit->getWidth() == splitInfo.iLeftWidth);
> -#else
> - UT_ASSERT((UT_sint32)pRunToSplit->getWidth() == splitInfo.iLeftWidth);
> -#endif
>
I left that in in case we needed to revert. In any case I think abiword in
this mode is much more user-friendly than when using layoutunits. Text
does not extend past the left margin and there are no more disappearing
runs in full justification.
Cheers
Martin
This archive was generated by hypermail 2.1.4 : Fri Jan 24 2003 - 14:31:28 EST