Re: change #define to static const for plugins

From: Dom Lachowicz (domlachowicz@yahoo.com)
Date: Thu Mar 13 2003 - 18:13:12 EST

  • Next message: Pierre Abbat: "commit: update Albanian, fix German typos"

    Cool, if you want to look into that, great. If you
    want to maybe looking into using
    http://sourceforge.net/projects/libmswrite/ for
    mswrite import and export, that'd be a good start at
    learning our imp/exp architecture.

    Dom

    --- Larin Hennessy <larin@science.oregonstate.edu>
    wrote:
    > I was actually thinking about the possibility of
    > using the OpenSP
    > library that is used by the openjade DocBook
    > processing program.
    >
    > I have not looked at it too closely yet, but it
    > could give AbiWord
    > a much more complete DocBook parser.
    >
    > -Larin
    >
    > Dom Lachowicz wrote:
    >
    > >Will look into these. Please, don't anyone apply
    > the
    > >docbook patch. I've got ideas for considerable
    > further
    > >improvement for this and the XSL-FO plugin.
    > >
    > >Dom
    > >
    > >--- Larin Hennessy <larin@science.oregonstate.edu>
    > >wrote:
    > >
    > >
    > >>I went through the abiword plugin
    > >>importer/exporters, and noticed several
    > >>places that #define was being used that could be
    > >>replaced with static const.
    > >>There were a couple of C header files in those
    > >>directories that I left
    > >>alone.
    > >>Should the C files be converted to C++ at some
    > >>point? In particular the rc5
    > >>files.
    > >>
    > >>Here are all my changes (except for the DocBook
    > >>changes submitted as part
    > >>of pr1812).
    > >>
    > >>-Larin
    > >>
    > >>
    > >>
    > >
    > >
    > >
    > >>ATTACHMENT part 2 application/x-gzip
    > >>
    > >>
    > >name=OpenWriter.diff.gz
    > >
    > >
    > >
    > >
    > >>ATTACHMENT part 3 application/x-gzip
    > >>
    > >>
    > >name=applix.diff.gz
    > >
    > >
    > >
    > >
    > >>ATTACHMENT part 4 application/x-gzip
    > >>
    > >>
    > >name=coquille.diff.gz
    > >
    > >
    > >
    > >
    > >>ATTACHMENT part 5 application/x-gzip
    > >>
    > >>
    > >name=hrtext.diff.gz
    > >
    > >
    > >
    > >
    > >>ATTACHMENT part 6 application/x-gzip
    > >>
    > >>
    > >name=html.diff.gz
    > >
    > >
    > >
    > >
    > >>ATTACHMENT part 7 application/x-gzip
    > >>
    > >>
    > >name=iscii.diff.gz
    > >
    > >
    > >
    > >
    > >>ATTACHMENT part 8 application/x-gzip
    > >>
    > >>
    > >name=kword.diff.gz
    > >
    > >
    > >
    > >
    > >>ATTACHMENT part 9 application/x-gzip
    > >>
    > >>
    > >name=latex.diff.gz
    > >
    > >
    > >
    > >
    > >>ATTACHMENT part 10 application/x-gzip
    > >>
    > >>
    > >name=mif.diff.gz
    > >
    > >
    > >
    > >
    > >>ATTACHMENT part 11 application/x-gzip
    > >>
    > >>
    > >name=mswrite.diff.gz
    > >
    > >
    > >
    > >
    > >>ATTACHMENT part 12 application/x-gzip
    > >>
    > >>
    > >name=pdb.diff.gz
    > >
    > >
    > >
    > >
    > >>ATTACHMENT part 13 application/x-gzip
    > >>
    > >>
    > >name=xsl-fo.diff.gz
    > >
    > >
    > >
    > >__________________________________________________
    > >Do you Yahoo!?
    > >Yahoo! Web Hosting - establish your business online
    > >http://webhosting.yahoo.com
    > >
    > >
    >
    >

    __________________________________________________
    Do you Yahoo!?
    Yahoo! Web Hosting - establish your business online
    http://webhosting.yahoo.com

    This archive was generated by hypermail 2.1.4 : Thu Mar 13 2003 - 18:20:15 EST