commit (HEAD): rtf imp

From: Tomas Frydrych (tomas@frydrych.uklinux.net)
Date: Fri May 09 2003 - 04:11:52 EDT

  • Next message: Tomas Frydrych: "commit (HEAD): fix 5072"

    Hi Martin,

    I have had a quick look and reversing my changes back from 0 to 1 on
    lines 1122, 4255, 4257 and 4263 makes document 4111 import again. The
    latter three, I think are wrong, I misread the code there. However, I
    am pretty sure the initialisation at line 1122 needs to be to 0,
    because 1 results in a call to OpenTable even if there is no table in
    the document. I have now reversed the latter three changes leaving
    the first one, and 4111 still does not import.

    You might want to have a look at the rtf docs with bug 4473; if
    m_tableLevel is initialised to 1 the doc created with word XP and
    saved in XP rtf imports fine, but it triggers a superfluos call to
    OpenTable, as the DBG output shows. However, the doc created and
    saved in Word 97 rtf does not import correctly, as you will see when
    comparing it to the PNG provided: the paragraph breaks are inserted
    at wrong place. This is caused by the superfluous call to OpenTable()
    which in this case flushes the characters without inserting the
    paragraph. As neither of these documents contains tables, the call to
    OpenTable() seems to be a bug, and initialising m_tableLevel to 0
    eradicates it.

    I will not have time for looking into this further until Sunday
    evening.

    Tomas

    > On Fri, 2003-05-09 at 02:20, Tomas Frydrych wrote:
    > > fixed character style import
    > >
    > > file: ie_imp_RTF.cpp/h
    >
    > HI Tomas,
    > The document in bug 4111 no longer imports on my build. I noticed in
    > bonsai this comment near your commit. // // Look to see if
    > m_bNestTableProps is true for nested tables. // //
    > changed the 1 to 0, because get getNestDepth() returns 0 for
    > // unnested table -- see ie_Table.cpp (Tomas,
    > May 8, 2003)
    >
    > else if((m_TableControl.getNestDepth() > 0) &&
    > !m_bNestTableProps) {
    > while(m_TableControl.getNestDepth() > 0)
    >
    > But I see no commit in Bonsai for ie_Table.cpp. Did you forget to
    > commit it?
    >
    > Cheers
    >
    > Martin
    >
    >
    > --
    > Martin Sevior <msevior@physics.unimelb.edu.au>
    > University of Melbourne
    >

    This archive was generated by hypermail 2.1.4 : Fri May 09 2003 - 04:26:15 EDT