From: Tomas Frydrych (tomasfrydrych_at_yahoo.co.uk)
Date: Sun Nov 30 2003 - 16:12:40 EST
> Since UT_strcoll is cross plataform and can be used in XP code, I
> think that any Win32 depency introduced by it should be solved
> where it is defined. Removing the include will cause undefined
> lstrcmpA errors where UT_strcoll is used under win32. And if you
> are using UT_strcoll in XP code (for example at
> xap_Dlg_Language.cpp), then you need to include windows.h.
I strongly disagree; I do not want windows.h included in any XP
files, this beats the whole point of having a portable XP layer.
> Since we need to include that file for lstrcmpA, I think that is
> better if we just do it in a single place, that is also where is
> defined and the dependency on that include is created, that's the
> reason why I add that include at UT_string.h.
Define a prototype for lstrcmpA using UT types just before the macro
definition instead.
> removing that include you are breaking the build under vc++/win32.
Actually, including windows.h from there broke things rather badly
for me; MSVC chocked completely up in Word and RTF imp/exp and some
other files before it gave up (because of custom type re-defintions
most of it from wv).
Tomas
This archive was generated by hypermail 2.1.4 : Sun Nov 30 2003 - 16:19:27 EST