Re: PATCH: Next 5291 speedup

From: Johnny Lee (typo_pl@hotmail.com)
Date: Thu Oct 02 2003 - 05:32:01 EDT

  • Next message: Dom Lachowicz: "Re: PATCH: Next 5291 speedup"

    Well, running Abiword under the debugger can skew the import time. Big oops.

    So after going back and re-measuring, here's the times for importing the RTF
    doc, and importing and building the RTF doc using Abiword along with the
    various patches. Also timed Word for comparison.

    Import Import+Build

    68 92 Abiword 2.0.0
    16 33 Abiword + Patch 1
    9 26 Abiword + Patches 1-2
    4 23 Abiword + Patches 1-3

    3 8 Word 2000

    I updated the corresponding web page,
    <http://www.geocities.com/typopl/bug5291.html>

    J

    >From: "Johnny Lee" <typo_pl@hotmail.com>
    >To: domlachowicz@yahoo.com, abiword-dev@abisource.com
    >Subject: Re: PATCH: Next 5291 speedup
    >Date: Wed, 01 Oct 2003 19:25:03 +0000
    >
    >Fine with me. I just wanted to stop the code from executing in the release
    >version.
    >
    >With all the changes, you may want to look and see if you can replace the
    >sorted insert and binary search in pp_TableAttrProp with an RB tree as
    >Martin had tried. The only reason I haven't switched the code to use an RB
    >tree is that I don't how the RB tree class in Abiword handles the
    >following:
    >
    >- inserting objects with duplicate keys
    >- finding all objects containing a specific key.
    >
    >J
    >
    >>From: Dom Lachowicz <domlachowicz@yahoo.com>
    >>To: AbiWord <abiword-dev@abisource.com>
    >>Subject: Re: PATCH: Next 5291 speedup
    >>Date: Wed, 1 Oct 2003 07:12:17 -0700 (PDT)
    >>
    >>Great catch. I don't want to commit the 2nd patch -
    >>I'd rather remove the diagnostic parts altogether. Abi
    >>is already too verbose when it comes to diagnostics,
    >>and this diagnostic was already disabled
    >>(xxx_UT_DEBUGMSG).
    >>
    >>I'll commit these tonight. Keep the patches coming :)
    >>
    >>Dom
    >>
    >
    >_________________________________________________________________
    >Get McAfee virus scanning and cleaning of incoming attachments. Get
    >Hotmail Extra Storage! http://join.msn.com/?PAGE=features/es
    >

    _________________________________________________________________
    Get McAfee virus scanning and cleaning of incoming attachments. Get Hotmail
    Extra Storage! http://join.msn.com/?PAGE=features/es

    This archive was generated by hypermail 2.1.4 : Thu Oct 02 2003 - 05:47:29 EDT