Re: PATCH: Next 5291 speedup

From: msevior@physics.unimelb.edu.au
Date: Thu Oct 02 2003 - 09:31:46 EDT

  • Next message: Jordi Mas: "Re: Commit: 5829"

    >
    > Well, running Abiword under the debugger can skew the import time. Big
    > oops.
    >
    > So after going back and re-measuring, here's the times for importing the
    > RTF doc, and importing and building the RTF doc using Abiword along
    > with the various patches. Also timed Word for comparison.
    >
    > Import Import+Build
    >
    > 68 92 Abiword 2.0.0
    > 16 33 Abiword + Patch 1
    > 9 26 Abiword + Patches 1-2
    > 4 23 Abiword + Patches 1-3
    >
    > 3 8 Word 2000
    >

    Hi Johnny,
             Thanks very much for this work. There are two next steps I can
    think of.

    1. Try the same thing with the word version of the document. (I think
    there is some code in the MS Word importer that makes some too general
    asumptions and could easily be optimized.)

    2. Try profiling the layout fill phase to see if there is anything in
    particular that is a bottleneck. We're currently using the GTK table
    layout algorithim which is extremely robust but might be the cause of the
    slow fill time in the those huge tables.

    In any case we need to know.

    However for the average user the Time to first document view is vastly
    improved. From over one minute to 4 seconds. That's a huge improvement.

    Congrats!

    Martin

    > I updated the corresponding web page,
    > <http://www.geocities.com/typopl/bug5291.html>
    >
    > J
    >
    >
    >>From: "Johnny Lee" <typo_pl@hotmail.com>
    >>To: domlachowicz@yahoo.com, abiword-dev@abisource.com
    >>Subject: Re: PATCH: Next 5291 speedup
    >>Date: Wed, 01 Oct 2003 19:25:03 +0000
    >>
    >>Fine with me. I just wanted to stop the code from executing in the
    >> release version.
    >>
    >>With all the changes, you may want to look and see if you can replace
    >> the sorted insert and binary search in pp_TableAttrProp with an RB
    >> tree as Martin had tried. The only reason I haven't switched the code
    >> to use an RB tree is that I don't how the RB tree class in Abiword
    >> handles the following:
    >>
    >>- inserting objects with duplicate keys
    >>- finding all objects containing a specific key.
    >>
    >>J
    >>
    >>>From: Dom Lachowicz <domlachowicz@yahoo.com>
    >>>To: AbiWord <abiword-dev@abisource.com>
    >>>Subject: Re: PATCH: Next 5291 speedup
    >>>Date: Wed, 1 Oct 2003 07:12:17 -0700 (PDT)
    >>>
    >>>Great catch. I don't want to commit the 2nd patch -
    >>>I'd rather remove the diagnostic parts altogether. Abi
    >>>is already too verbose when it comes to diagnostics,
    >>>and this diagnostic was already disabled
    >>>(xxx_UT_DEBUGMSG).
    >>>
    >>>I'll commit these tonight. Keep the patches coming :)
    >>>
    >>>Dom
    >>>
    >>
    >>_________________________________________________________________ Get
    >> McAfee virus scanning and cleaning of incoming attachments. Get
    >> Hotmail Extra Storage! http://join.msn.com/?PAGE=features/es
    >>
    >
    > _________________________________________________________________
    > Get McAfee virus scanning and cleaning of incoming attachments. Get
    > Hotmail Extra Storage! http://join.msn.com/?PAGE=features/es

    This archive was generated by hypermail 2.1.4 : Thu Oct 02 2003 - 09:52:02 EDT