Re: patch: fixes zoom page under win32

From: msevior@physics.unimelb.edu.au
Date: Mon Sep 01 2003 - 11:06:14 EDT

  • Next message: Dom Lachowicz: "Re: Enchant 0.4.0 released"

    > Hello,
    >
    > This patch fixes two bugs related two win32 zooming:
    >
    > - First, at EV_Win32Toolbar::_ComboWndProc we were getting a string from
    > a combobox and then we were using the UT_UCS4_strcpy_utf8_char
    > function instead of UT_UCS4_strcpy_char. Remember that our Windows
    > win32 build uses ANSI strings converted to the user locale. Not Unicode
    > not UTF-8. When the Zoom strings had special characters (e.g. were
    > localised) the conversion was wrong.
    >
    > - Second, the function Defun(zoom) at ap_EditMethods.cpp was using
    > getValue to obtain UTF8 strings from the StringSet. Remember, that many
    > Unices locales work on UTF-8 but in Windows we do not use UTF-8 and
    > under win32 we were getting ANSI encoded strings instead of UTF8!. You
    > XP wizards guys remember to use getValueUTF8 if you really want a UTF-8
    > encoded string.
    >
    > This this two fixes now we you select the Zoom View to a non-numeric
    > value with localised version of Windows works, before was not working.
    >
    > I hope that this makes sense to everyone.
    >

    Hi Jordi,
             Could make a "diff -u" patch and send it to the list? Since the
    patch touches xp code I want to make I sure In understand what is
    happenning.

    Thanks!

    Martin

    > Best Regards,
    > --
    >
    > Jordi Mas i Hernāndez - Abiword developer - http://www.abisource.com
    > jmas@softcatala.org - Softcatalā member - http://www.softcatala.org
    > - Personal Homepage
    > http://www.softcatala.org/~jmas



    This archive was generated by hypermail 2.1.4 : Mon Sep 01 2003 - 11:22:02 EDT