Re: commit: fix serbian string set loading

From: Andrew Dunbar (hippietrail@yahoo.com)
Date: Thu Sep 11 2003 - 19:25:19 EDT

  • Next message: Andrew Dunbar: "Re: Requesting help for completing the missing translations"

    Hi Jordi.
    This appears to be the wrong fix. As always, please
    check the ISO language and country tables when making
    any changes to language tags. According to this page
    at least:
    http://sources.redhat.com/ml/bug-glibc/2003-06/msg00012.html
    Serbia as a separate country does not yet have an ISO
    code so "SR" is not correct. I'm pretty sure I've
    heard
    that Serbia and Montenegro were finally splitting but
    until that split the union has still been known as
    Yugoslavia. As my comment in the source suggests, this
    would be "sr-YU". Since there are likely to be systems
    with sr-* and perhaps various country codes, it seems
    a much better solution to just use "sr" with no
    country code. At least until ISO adds a code for
    Serbia
    and probably until the various Unixes adopt that code.
    In the meantime we should be changing the name of the
    strings file (and anything else) to "sr" rather than
    changing the source to "sr-SR".

    Andrew Dunbar.

     --- Jordi Mas <jmas@softcatala.org> wrote: >
    Currently the name of the serbian string set is
    > "sr-SR.strings" but we have in
    > the locale table "sr". This inconsistence was
    > causing the Serbian string file
    > not been found and loaded.
    >
    > Attached the proposed patch.
    >
    > Best Regards,
    > --
    >
    > Jordi Mas i Hernāndez - Abiword developer -
    > http://www.abisource.com
    > jmas@softcatala.org - Softcatalā member -
    > http://www.softcatala.org
    > - Personal Homepage
    > http://www.softcatala.org/~jmas
    > > Index: src/af/util/xp/ut_Language.cpp
    >
    ===================================================================
    > RCS file:
    > /cvsroot/abi/src/af/util/xp/ut_Language.cpp,v
    > retrieving revision 1.41
    > diff -u -r1.41 ut_Language.cpp
    > --- src/af/util/xp/ut_Language.cpp 8 Jun 2003
    > 13:21:36 -0000 1.41
    > +++ src/af/util/xp/ut_Language.cpp 11 Sep 2003
    > 14:57:10 -0000
    > @@ -113,7 +113,7 @@
    > {"sk-SK", NULL, XAP_STRING_ID_LANG_SK_SK,
    > UTLANG_LTR},
    > {"sl-SI", NULL, XAP_STRING_ID_LANG_SL_SI,
    > UTLANG_LTR},
    > {"sq-AL", NULL, XAP_STRING_ID_LANG_SQ_AL,
    > UTLANG_LTR},
    > - {"sr", NULL, XAP_STRING_ID_LANG_SR,
    > UTLANG_LTR}, // Why not sr-YU?
    > + {"sr-SR", NULL, XAP_STRING_ID_LANG_SR,
    > UTLANG_LTR}, // Why not sr-YU?
    > {"sv-SE", NULL, XAP_STRING_ID_LANG_SV_SE,
    > UTLANG_LTR},
    > {"th-TH", NULL, XAP_STRING_ID_LANG_TH_TH,
    > UTLANG_LTR},
    > {"tr-TR", NULL, XAP_STRING_ID_LANG_TR_TR,
    > UTLANG_LTR}, // UTLANG_RTL for Ottoman Turkish
    >

    =====
    http://linguaphile.sf.net/cgi-bin/translator.pl http://www.abisource.com

    ________________________________________________________________________
    Want to chat instantly with your online friends? Get the FREE Yahoo!
    Messenger http://mail.messenger.yahoo.co.uk

    This archive was generated by hypermail 2.1.4 : Thu Sep 11 2003 - 19:38:44 EDT