Re: [Fwd: bug fix for 5730 breaks the build]

From: Marc Maurer (j.m.maurer@student.utwente.nl)
Date: Fri Sep 12 2003 - 15:08:46 EDT

  • Next message: Marc Maurer: "Re: [Fwd: bug fix for 5730 breaks the build]"

    Someone else should do this (Jeremy?), since I don't have access to a
    win32 box today

    Marc

    Op vr 12-09-2003, om 20:58 schreef Kenneth J. Davis:
    > Well Dom's committed patch is also wrong as it breaks my cygwin/MSVC
    > builds. Can someone explain to me why the MinGW build needs two
    > slashes(//) instead of one? [I know \ usually needs escaped but / ?]
    > Personally I think the proper fix is to change the comment to the
    > plugin is required and let the build fail than the committed workaround,
    > as the plugin is now required on Windows. Anyway, please fix by
    > either reverting the patches and changing the error message or
    > wrap the weird double slash hack into the MinGW section and use a
    > single slash for the other Windows compilers.
    >
    > Thanks,
    > Jeremy
    > :-)
    >
    >
    > On 11 Sep 2003 13:56:58 +0200 Marc Maurer <j.m.maurer@student.utwente.nl> wrote:
    >
    > MM> I can't build for win32 right now, so could some of you win32 guys have
    > MM> a look?
    > MM>
    > MM> Thx,
    > MM> Marc
    > MM>
    > MM> Hi Marc
    > MM>
    > MM> That patch for bug 5730 breaks the 'make distribution' process.
    > ...
    > MM> I think the makefile incorrect has in line 57
    > MM>
    > MM> NSIS_OPT += /DHAVEBMP=1
    > MM>
    > MM> which seems to be wrong?
    > MM>
    > MM> Thanks
    >
    >

    -- 
    Marc Maurer <j.m.maurer@student.utwente.nl>
    


    This archive was generated by hypermail 2.1.4 : Fri Sep 12 2003 - 15:15:50 EDT