Re: commit (HEAD): xap_Strings.h/cpp

From: Tomas Frydrych (tomasfrydrych_at_yahoo.co.uk)
Date: Sat Apr 10 2004 - 10:02:06 EDT

  • Next message: Tomas Frydrych: "Re: Removing unneeded preferences"

    > > So, my proposal is to remove UT_String getValue() and change the
    > > other to char * getValueUTF8().
    >
    > I actually vote for this one. It's much cleaner, and we don't need a full copy of the object in the 1st place.
    >

    The only drawback with this, and I suspect that is why the
    UT_UTF8String variant was introduced in the first place, is that the
    caller is responsible for deleting the returned string, hence there
    is potential for leaks.

    Another possibility that I think I would prefer is to have

         void getValueUTF8(XAP_String_Id id, UT_UTF8String & s);

    This eliminates both problems.

    Tomas

    This archive was generated by hypermail 2.1.4 : Sat Apr 10 2004 - 10:05:21 EDT