Re: commit: Re: commit: Fix changeStrux with revision Marks.

• Previous message: Mikey Cooper: "Patch: Splash screen not centered/displayed properly on win32"
• In reply to: msevior_at_physics.unimelb.edu.au: "commit: Re: commit: Fix changeStrux with revision Marks."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Hi Martin,

> I do have a question about all this. Right now with revision marks on, you
> do a regular insert with the requested properties followed by a change
> strux with the revision marks.
>
> This is not a good idea for performance or undo.
>
> The performance thing is that every layout is built then rebuilt with the
> change strux.
>
> The undo is that unless the change strux is rolled into the insert with a
> glob marker, the change strux is popped off the undo stack seperately from
> the insert.
>
> You see this when you undo regular typing with the document history turned
> on.
>
> (compare with what happens with document history turned off. You see
> contiguous typing undone in one click as opposed to seperate clicks. It
> actually worse because depending on which click the user ends on the
> revision marks may or maynot be recorded for the last undo operation.)
>
> Anyway, wouldn't it be better to roll the revision mark generation into
> the initial operation? Then every action is atomic.

That is a good point; I will fix that.

Tomas

• Next message: Tomas Frydrych: "commit (HEAD): optimize strux/object insertion in revision mode"
• Previous message: Mikey Cooper: "Patch: Splash screen not centered/displayed properly on win32"
• In reply to: msevior_at_physics.unimelb.edu.au: "commit: Re: commit: Fix changeStrux with revision Marks."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

This archive was generated by hypermail 2.1.4 : Sat Apr 17 2004 - 02:44:05 EDT