RE: commit (head): fix 7011

With this change, it looks like PD_Document requires m_pDoc in numerous
places, which is only defined when using PT_TEST in
pd_Document_TestRoutines.cpp. Currently, only Debug builds define
PT_TEST, so the win32 release build is broken. Do we need to define
PT_TEST for Release builds now?

-----Original Message-----
From: Tomas Frydrych [mailto:tomasfrydrych@yahoo.co.uk]
Sent: Thursday, August 05, 2004 6:21 AM
To: abiword-dev@abisource.com
Subject: commit (head): fix 7011

This substantial commit fixes bug 7011, table cells do not merge with
doc history on. Basically, the problem is that much of the table
manipulation code queries the piecetable directly for properties and
attributes, which bypasses the whole revisioning stuff (props and
attributes in revisioned documents are always function of the view and
can be substantially different for different simultaneous views of the
same document). I have modified several PD_Document functions to fix
this.

This bug touches on a much bigger issue that we will need to look into
after 2.2, namely clear separation between document and views.
Layout classes and dialogues should not be able to carry out any
operations (whether passive or active) on the document, only on the view
they belong to; document operations should be restricted to the view
alone. Correspondingly, importers and the document should not be allow
to do any operations on layout classes, only send notifications to the
view (for example, at the moment both fl_BlockLayout, PD_Document and
several importers construct fl_AutoNumber instances).

Tomas

files: number in imp/exp, text/fmt, text/ptbl and wp/ap
Received on Thu Aug 5 18:07:14 2004