Re: Commit: fix MinGW build

Hm, I really do not like this, and I fear if you leave it it will be
left that way. Quite apart from the maintanence issue, the rc2 file is a
bad place for it; if you do want to define it, it should be in some
header file that will make it avialable to other dlgs, etc.

Tomas

sum1_lists@yahoo.com wrote:
>
> --- Tomas Frydrych <tomasfrydrych@yahoo.co.uk> wrote:
>
>
>>Hi Sum,
>>
>>Please revert this. We have now determined that this
>>constant _is_
>>defined on MingW, but only if IE 4+ is assumend, so
>>the correct solution
>>is to pass whatever flags required to MingW to
>>define this for us (it's
>>a question of maintanability; let someone else worry
>>about what the
>>numerical value of this constant should be when
>>Windows 3000 comes along).
>
>
> I agree that this is hacky, but I think the commit
> should stay until someone else has a proper fix for
> it. As far as I know, the ifndef won't hurt any other
> builds (please correct me if I'm wrong). I've filed
> this issue in bugzilla (#8200) so it's not forgotten.
>
>
>>(I gather we have basically agreed that we will no
>>longer support Win95
>>without IE 4+).
>>
>>Tomas
>>
>>
>
>
>
>
>
> __________________________________
> Do you Yahoo!?
> The all-new My Yahoo! - Get yours free!
> http://my.yahoo.com
>
>
>
Received on Thu Dec 23 11:34:52 2004