Re: [Fwd: 2.1.0 patch for amd64]

From: Hubert Figuiere (hfiguiere_at_teaser.fr)
Date: Sun Feb 01 2004 - 13:52:55 EST

  • Next message: hfiguiere_at_teaser.fr: "HELLO"

    According to Marc Maurer <j.m.maurer_at_student.utwente.nl>:
    > Forward: Patch from Noah Roberts to make abi compile on AMD64

    Don't apply this patch as is or I'll byte.

    There is a problem, but the proposed fix is just not the right thing
    to do.

    For example
    > - UT_UCSChar c1 = static_cast<UT_UCSChar>(reinterpret_cast<UT_uint32>(coverage[i]));
    > + UT_UCSChar c1 = static_cast<UT_UCSChar>(reinterpret_cast<unsigned long>(coverage[i]));

    Replacing a cast from <UT_uint32> to <unsigned long> is bad.
    Better find out what is wrong there to have better defined type.

    One of the main problems is that we store UT_uint32 in place of void*
    in vectors...

    See bug 3636 in bugzilla.

    Hub 

    -- 
AbiWord maintainer - Lille, France
http://www.figuiere.net/hub/ 
GPG fingerprint: 6C44 DB3E 0BF3 EAF5 B433  239A 5FEE 05E6 A56E 15A3

    This archive was generated by hypermail 2.1.4 : Sun Feb 01 2004 - 13:54:59 EST