Re: [Fwd: 2.1.0 patch for amd64]

From: Mark Gilbert (mg_abimail_at_yahoo.com)
Date: Sun Feb 01 2004 - 17:10:27 EST

  • Next message: Martin Sevior: "Re: [Fwd: 2.1.0 patch for amd64]"

    Hub is right. Besides, there are many _many_ similar warnings, and they only bite if you tell
    your compiler (assuming it is gcc) to make them errors.

    FWIW, I am on amd64, and abi (HEAD) builds just fine except for one tiny little thing that dom
    committed the fix for already. Tons of compile warnings, and some crashes that martin thinks
    could be 64-bit related (we're working on it), but it builds.

    --- Hubert Figuiere <hfiguiere_at_teaser.fr> wrote:
    > According to Marc Maurer <j.m.maurer_at_student.utwente.nl>:
    > > Forward: Patch from Noah Roberts to make abi compile on AMD64
    >
    > Don't apply this patch as is or I'll byte.
    >
    > There is a problem, but the proposed fix is just not the right thing
    > to do.
    >
    > For example
    > > - UT_UCSChar c1 = static_cast<UT_UCSChar>(reinterpret_cast<UT_uint32>(coverage[i]));
    > > + UT_UCSChar c1 = static_cast<UT_UCSChar>(reinterpret_cast<unsigned long>(coverage[i]));
    >
    > Replacing a cast from <UT_uint32> to <unsigned long> is bad.
    > Better find out what is wrong there to have better defined type.
    >
    > One of the main problems is that we store UT_uint32 in place of void*
    > in vectors...
    >
    > See bug 3636 in bugzilla.
    >
    > Hub
    > --
    > AbiWord maintainer - Lille, France
    > http://www.figuiere.net/hub/
    > GPG fingerprint: 6C44 DB3E 0BF3 EAF5 B433 239A 5FEE 05E6 A56E 15A3

    __________________________________
    Do you Yahoo!?
    Yahoo! SiteBuilder - Free web site building tool. Try it!
    http://webhosting.yahoo.com/ps/sb/

    This archive was generated by hypermail 2.1.4 : Sun Feb 01 2004 - 17:12:29 EST