REVERT: Re: commit (head): toggle case fixes

From: Martin Sevior <msevior_at_physics.unimelb.edu.au>
Date: Mon Sep 20 2004 - 06:53:55 CEST

cvs update -j1.730 -j1.729 src/wp/ap/xp/ap_EditMethods.cpp
cvs update -j1.180 -j1.179 src/text/fmt/xp/fv_View_protected.cpp
cvs update -j1.340 -j1.339 src/text/fmt/xp/fv_View.h
cvs update -j1.975 -j1.974 src/text/fmt/xp/fv_View.cpp
cvs update -j1.16 -j1.15 src/text/ptbl/xp/pt_PT_FmtMark.cpp
cvs update -j1.121 -j1.120 src/text/ptbl/xp/pt_PieceTable.h
cvs update -j1.222 -j1.221 src/text/ptbl/xp/pd_Document.h
cvs update -j1.330 -j1.329 src/text/ptbl/xp/pd_Document.cpp
Thanks mikey for the CVS MAgic.

This commit broke footnotes.

1. Blank document.
2. Insert footnote.
ASSERT!
3. Type in footnote on second key press, crash!

sum1 also reports merge cells broken after this commit.

Have another look at your code Tomas and see what's going wrong with
format marks.

Good Luck!

Martin

On Sun, 2004-09-19 at 01:09, Tomas Frydrych wrote:
> various fixes to the toggle case code, including bug 6430.
>
> In order to get this sorted I had to make changes to
> pt_PieceTable::_insertFmtMarkFragWithNotify -- basically the original
> code tried to be too clever, doing things that are better done on
> higher level than the PT. The two significant changes are:
>
> (1) the fmt mark simply holds the fmt that has been passed down to
> it; it does not try to supperimpose it on props and attrs derrived
> from the context; that is the job of the caller. (I created
> FV_View::getAttrPropForPoint() to simplyfy handling of fmt continuity
> at point).
>
> (2) Immediately after the start of a strux, fmt mark is inserted,
> even if it seemingly has no effect -- without this the
> _chooseIndexAP() does not work.
>
> I also came across a situation where UT_Worker was firing recursively
> inside _sFrequentRepeat(), so I added code to stop that from
> happening.
>
> files: number in ptbl/xp and fv_View*.h/cpp, ap_EditMethods.cpp
>
> Tomas
>
>
>
Received on Mon Sep 20 06:10:09 2004

This archive was generated by hypermail 2.1.8 : Mon Sep 20 2004 - 06:10:09 CEST