Re: REVERT: Re: commit (head): toggle case fixes

Thanks Martin. This was one pre-mature commit -- my appologies to
everyone.

Tomas

>
> This commit broke footnotes.
>
> 1. Blank document.
> 2. Insert footnote.
> ASSERT!
> 3. Type in footnote on second key press, crash!
>
> sum1 also reports merge cells broken after this commit.
>
> Have another look at your code Tomas and see what's going wrong with
> format marks.
>
> Good Luck!
>
> Martin
>
>
>
>
> On Sun, 2004-09-19 at 01:09, Tomas Frydrych wrote:
> > various fixes to the toggle case code, including bug 6430.
> >
> > In order to get this sorted I had to make changes to
> > pt_PieceTable::_insertFmtMarkFragWithNotify -- basically the original
> > code tried to be too clever, doing things that are better done on
> > higher level than the PT. The two significant changes are:
> >
> > (1) the fmt mark simply holds the fmt that has been passed down to
> > it; it does not try to supperimpose it on props and attrs derrived
> > from the context; that is the job of the caller. (I created
> > FV_View::getAttrPropForPoint() to simplyfy handling of fmt continuity
> > at point).
> >
> > (2) Immediately after the start of a strux, fmt mark is inserted,
> > even if it seemingly has no effect -- without this the
> > _chooseIndexAP() does not work.
> >
> > I also came across a situation where UT_Worker was firing recursively
> > inside _sFrequentRepeat(), so I added code to stop that from
> > happening.
> >
> > files: number in ptbl/xp and fv_View*.h/cpp, ap_EditMethods.cpp
> >
> > Tomas
> >
> >
> >
>
Received on Mon Sep 20 11:55:28 2004