Re: My Second OpenDocument patch

Hi Daniel,

1) Please make the spacing between methods just one
line.
2) Please don't include patches that do 3 separate
things. The most important bit here is "Improves style
import/export", and yet those changes are buried
between two other sets of changes. It only serves to
obfuscate the real work done.

Thanks,
Dom

--- Daniel d'Andrada Tenório de Carvalho
<daniel.carvalho@indt.org.br> wrote:

> Hi guys,
>
> Attached to this e-mail is my new patch for the
> OpenDocument plugin. It
> does the following (in order of importance):
>
> 1 - Increases the modularization of the code, mainly
> regarding to styles.
>
> 2 - Improves styles handling/import.
>
> 3 - Makes the spacing between methods even (5 lines)
> for most files. So,
> if you see entries on the patch just adding or
> removing blank lines
> don't go mad on me. :-)
>
> What do you guys think? Good for commit?
>
> My next patch (within some days) should add
> header/footer support.
>
> Best Regards,
> Daniel d'Andrada T. de Carvalho - INdT
>

                
____________________________________________________
Start your day with Yahoo! - make it your home page
http://www.yahoo.com/r/hs
 
Received on Thu Jul 21 21:19:56 2005