Re: patch for gr_UnixImage.cpp

On Sun, 2005-11-27 at 15:49 +0100, Jean Bréfort wrote:
> Hi,
>
> recent changes to gr_UnixImage.cpp (1.39->1.40) broke charts. Here is a
> patch which fixes that.
> I found another problem: changing the height of the chart (or another
> embedded object) does not change ascent and descent, and descent is
> calculated with :
> iDescent = UT_convertToLogicalUnits(pszHeight) - iAscent;
> so it can become negative... IMHO, both ascent and descent should be
> changed proportionally when height change.
> This can be done easily in fp_EmbedRun.cpp. Any comment?
>

Hi Jean,
        Thanks for the patch. It looks OK. I'll apply it after I resynch
my tree.

Regarding the EmbedRun problem. Do have a test case that illustrates the
problem?

As far as I know, all embed runs to date have 0 for their descent.

Cheers

Martin

> Cheers,
> Jean
Received on Mon Nov 28 00:59:19 2005