Re: PATCH: Fix bug 9548

From: <msevior_at_physics.unimelb.edu.au>
Date: Mon Sep 26 2005 - 12:24:31 CEST

>
> On Mon, 2005-09-26 at 15:24 +1000, msevior@physics.unimelb.edu.au wrote:
>> Here is the patch to fix the blocker 9548.
>>
>> I'll commit later if there are no objections
>
> Two small issues:
>
> 1. When a user hits save now, the save dialog pops up with .abw selected
> as the default save format. This imo is a sane thing to do, however the
> extension of the original file name is still set to .odt. Most users
> will just press ok, "corrupting" their ODT document. Wouldn't it be wise
> to change the extention as well?
>

I agree. Will do.

> 2. The hardcoded "1" for .abw in xap_Frame.cpp seems scary
>

Yes but doing the "right thing" requires putting ie_exp.h into
src/af/xap/xp which is currently forbidden.

This seemmed like the lesser of the evils and has a comment associated
with it.

Cheers

Martin

> Otherwise it works fine. Better than the current behavior :)
>
> Marc
>
>
Received on Mon Sep 26 12:26:42 2005

This archive was generated by hypermail 2.1.8 : Mon Sep 26 2005 - 12:26:43 CEST