Re: CVS: commit msevior abi/src/wp/ap/xp ap_FrameData.h

From: J.M. Maurer <uwog_at_uwog.net>
Date: Sat Nov 25 2006 - 16:13:41 CET

> Index: ap_FrameData.h
> ===================================================================
> RCS file: /cvsroot/abi/src/wp/ap/xp/ap_FrameData.h,v
> retrieving revision 1.17
> retrieving revision 1.18
> diff -u -d -r1.17 -r1.18
> --- ap_FrameData.h 26 Jan 2006 12:48:48 -0000 1.17
> +++ ap_FrameData.h 25 Nov 2006 14:23:09 -0000 1.18
> @@ -60,6 +60,7 @@
> EV_Toolbar * m_pToolbar[4]; // TODO: 4 = NB_OF_TOOLBARS...
> AP_StatusBar * m_pStatusBar;
> ViewMode m_pViewMode;
> + bool m_bIsWidget;
> };

Ick... shouldn't stuff like this be handled in the widget? Ie. the
widget should set the Normal mode, and disable the rulers on creation.

The AbiWord Frame code should not even know it can be used as a widget.
If we allow stuff like this, we soon get into the same mess as what
abicollab initially was :-P

Other than that, awesome work!

Cheers,
   Marc
Received on Sat Nov 25 16:16:11 2006

This archive was generated by hypermail 2.1.8 : Sat Nov 25 2006 - 16:16:12 CET