Re: CVS: commit msevior abi/src/wp/ap/xp ap_FrameData.h

>
>> Index: ap_FrameData.h
>> ===================================================================
>> RCS file: /cvsroot/abi/src/wp/ap/xp/ap_FrameData.h,v
>> retrieving revision 1.17
>> retrieving revision 1.18
>> diff -u -d -r1.17 -r1.18
>> --- ap_FrameData.h 26 Jan 2006 12:48:48 -0000 1.17
>> +++ ap_FrameData.h 25 Nov 2006 14:23:09 -0000 1.18
>> @@ -60,6 +60,7 @@
>> EV_Toolbar * m_pToolbar[4]; // TODO: 4 = NB_OF_TOOLBARS...
>> AP_StatusBar * m_pStatusBar;
>> ViewMode m_pViewMode;
>> + bool m_bIsWidget;
>> };
>
> Ick... shouldn't stuff like this be handled in the widget? Ie. the
> widget should set the Normal mode, and disable the rulers on creation.
>
> The AbiWord Frame code should not even know it can be used as a widget.
> If we allow stuff like this, we soon get into the same mess as what
> abicollab initially was :-P
>

The problem is that FV_View determines whether or not to start in Normal
Mode based on a preference. We need to override that in the constructor,
without passing another parameter to the constructor.

I'll see if I can come up with a different way.

Cheers

Martin

> Other than that, awesome work!
>
> Cheers,
> Marc
>
>
Received on Sat Nov 25 22:14:57 2006