Re: CVS: commit msevior abi/src/af/ev/xp ev_EditBinding.cpp

From: Robert Staudinger <robert.staudinger_at_gmail.com>
Date: Thu Aug 30 2007 - 07:48:04 CEST

On 8/29/07, J.M. Maurer <uwog@uwog.net> wrote:
> > > +Up to to 6 buttons are available for the mouse. (B0, B1, B2, B3, B4, B5, B6)
> > > +The follow contexts are available:
> >
> > It seems you committed too much. And btw, why using a plain text file,
> > and not an xml description for this kind of stuff?
>
> Just to be more productive that just babbling something on the ML, how
> about the attached very simple xml file? It's so trivial, everyone
> should be able to understand it.
> Sure it's a bit more verbose than Martin's plain ascii file, but there I
> needed to look at the source to see what it actually did; this one is
> more obvious imo :)

What about that part "<modifier>shift,control</modifier>"? Are you
parsing the comma by hand? That would not be very xml. There is
nothing wrong writing

<modifier>shift</modifier>
<modifier>control</modifier>

within <namedvirtualkey>.

Also within <mousecontext> you write "<modifier>ctrl</modifier>". Does
it really make things simpler supporting the full and abbreviated
variant?

Cheers,
Rob
Received on Thu Aug 30 07:48:24 2007

This archive was generated by hypermail 2.1.8 : Thu Aug 30 2007 - 07:48:25 CEST