Re: CVS: commit msevior abi/src/af/ev/xp ev_EditBinding.cpp

On Thu, 2007-08-30 at 07:48 +0200, Robert Staudinger wrote:
> On 8/29/07, J.M. Maurer <uwog@uwog.net> wrote:
> > > > +Up to to 6 buttons are available for the mouse. (B0, B1, B2, B3, B4, B5, B6)
> > > > +The follow contexts are available:
> > >
> > > It seems you committed too much. And btw, why using a plain text file,
> > > and not an xml description for this kind of stuff?
> >
> > Just to be more productive that just babbling something on the ML, how
> > about the attached very simple xml file? It's so trivial, everyone
> > should be able to understand it.
> > Sure it's a bit more verbose than Martin's plain ascii file, but there I
> > needed to look at the source to see what it actually did; this one is
> > more obvious imo :)
>
> What about that part "<modifier>shift,control</modifier>"? Are you
> parsing the comma by hand? That would not be very xml. There is
> nothing wrong writing
>
> <modifier>shift</modifier>
> <modifier>control</modifier>

Good suggestion

> within <namedvirtualkey>.
>
> Also within <mousecontext> you write "<modifier>ctrl</modifier>". Does
> it really make things simpler supporting the full and abbreviated
> variant?

I guess not, I'll use 'control' there then.

Thanks for the feedback. More improvements are very welcome. When I
implement this, I'd like to have it as good as possible from the start.

Marc
Received on Thu Aug 30 11:34:17 2007