Re: CVS: commit uwog abiword-plugins/tools/abicollab/handlers/xmpp/xp XMPPAccountHandler.cpp

> - pManager->registerEventListener(this);
> + if (pManager)
> + {
> + pManager->registerEventListener(this);
> + }
> + else
> + UT_ASSERT(UT_SHOULD_NOT_HAPPEN);
> * more code could go here *

In a non-debug build, UT_ASSERT evaluates to nothing. So this code
fragment becomes syntactically invalid. Or worse, the next line gets
executed only if !pManager, instead of unconditionally.

Please place this stuff into brackets, or change UT_ASSERT's
definition in NDEBUG mode to be something like:

"do{}while(0)" or "void(0)"

The compiler's dead code elimination phase should optimize such a
block out, but still produce the desired result.

Thanks,
Dom

-- 
Counting bodies like sheep to the rhythm of the war drums.