Hi Rob,
Robert Staudinger wrote:
> On 1/23/07, Tomas Frydrych <tf@o-hand.com> wrote:
>>
>> Hi Rob,
>>
>> > class FL_DocLayout;
>> > @@ -978,7 +983,11 @@
>> > fv_PropCache m_SecProps;
>> > AV_ListenerId m_CaretListID;
>> > FV_FrameEdit m_FrameEdit;
>> > +#ifdef XP_UNIX_TARGET_GTK
>> > + FV_UnixVisualDrag m_VisualDragText;
>> > +#else
>> > FV_VisualDragText m_VisualDragText;
>> > +#endif
>>
>> Why is this necessary? I assume there are good reasons for this, but I
>> am very uneasy about introducing platform specific code into src/text,
>> and particularly src/text/fmt, so I would like to know bit more about
>> these changes. Thanks.
>
> This changes have been made to let platforms take advantage of native
> dnd APIs.
Could you please elaborate on that (i.e., what are you planning to do in
FV_UnixVisualDrag)?
> Whether src/text/fmt is the right place for dnd in the first place is
> debatable, of course. I've added it there because it already was
> there.
The current FV_VisualDrag is just a helper class for FV_View, and
text/fmt is not un unreasonable place for it. Whether this class itself
is the right place for any new platform-dependent functionality depends
on what it is you want to do with it.
Tomas
Received on Wed Jan 24 08:34:20 2007
This archive was generated by hypermail 2.1.8 : Wed Jan 24 2007 - 08:34:22 CET