Re: CVS: commit robsta abi/src/text/fmt/xp fv_View.h fv_VisualDragText.h

Robert Staudinger wrote:
>
> On 1/24/07, Tomas Frydrych <tf@o-hand.com> wrote:
>>
>> Hi Rob,
>>
>> Robert Staudinger wrote:
>> > On 1/23/07, Tomas Frydrych <tf@o-hand.com> wrote:
>> >>
>> >> Hi Rob,
>> >>
>> >> > class FL_DocLayout;
>> >> > @@ -978,7 +983,11 @@
>> >> > fv_PropCache m_SecProps;
>> >> > AV_ListenerId m_CaretListID;
>> >> > FV_FrameEdit m_FrameEdit;
>> >> > +#ifdef XP_UNIX_TARGET_GTK
>> >> > + FV_UnixVisualDrag m_VisualDragText;
>> >> > +#else
>> >> > FV_VisualDragText m_VisualDragText;
>> >> > +#endif
>> >>
>> >> Why is this necessary? I assume there are good reasons for this, but I
>> >> am very uneasy about introducing platform specific code into src/text,
>> >> and particularly src/text/fmt, so I would like to know bit more about
>> >> these changes. Thanks.
>> >
>> > This changes have been made to let platforms take advantage of native
>> > dnd APIs.
>>
>> Could you please elaborate on that (i.e., what are you planning to do in
>> FV_UnixVisualDrag)?
>
> Currently it is not possible to drag text outside of abiword (because
> a "grab" is done on the mouse pointer, i think). Tomeu is working on
> native gtk dnd support, so an image of the the dragged content would
> be set as drag icon. That would allow for keeping the xp "vdnd"
> feature as we have now /and/ let content be dragged outside the
> borders of the abiword window.

Ok, it will be really great to have this, and I appreciate you guys
working on it, but I think code that deals with dragging text outside
of the application and interfacing with the OS dnd mechanism should not
go into text/fmt but somewhere into af/xap (or wp/ap), with a suitable
xp interface that the layout engine (text/fmt) can be hooked into through.

If that means refactoring the internal vdnd, I have no objections to
that at all, as long as the changes are reversible if we run into too
many issues with this new feature (on past experience vdnd can become a
minefield of instability).

Tomas
Received on Wed Jan 24 10:54:31 2007