Re: Underline formatting button is gone

--- Jordi Mas <jmas@softcatala.org> wrote:

>
> Hello everyone,
>
> I want to bring you attention on revision 1.26 done at file
> ap_TB_Layouts_FormatOps.h on the 20/11/2006. See also:
>
http://www.abisource.com/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=ap_TB_Layouts_FormatOps.h&branch=&root=/cvsroot&subdir=abi/src/wp/ap/xp&command=DIFF_FRAMESET&rev1=1.26&rev2=1.27
>
> The definition for the underline button in the formatting toolbar
> menu was
> removed and other changes were done:
>
> ;-----------------------------------------------------------
> @@ -34,7 +36,6 @@
> Spacer()
> ToolbarItem(AP_TOOLBAR_ID_FMT_BOLD)
> ToolbarItem(AP_TOOLBAR_ID_FMT_ITALIC)
> - ToolbarItem(AP_TOOLBAR_ID_FMT_UNDERLINE)
>
> Spacer()
> ToolbarItem(AP_TOOLBAR_ID_ALIGN_LEFT)
> @@ -43,15 +44,10 @@
> ToolbarItem(AP_TOOLBAR_ID_ALIGN_JUSTIFY)
>
> Spacer()
> - ToolbarItem(AP_TOOLBAR_ID_LISTS_NUMBERS)
> - ToolbarItem(AP_TOOLBAR_ID_LISTS_BULLETS)
> + ToolbarItem(AP_TOOLBAR_ID_COLOR_BACK)
> + ToolbarItem(AP_TOOLBAR_ID_COLOR_FORE)
>
> - ToolbarItem(AP_TOOLBAR_ID_UNINDENT)
> - ToolbarItem(AP_TOOLBAR_ID_INDENT)
> + Spacer()
> + ToolbarItem(AP_TOOLBAR_ID_FMTPAINTER)
>
> - /* TODO: these should be moved out into the general public */
> - Spacer()
> - ToolbarItem(AP_TOOLBAR_ID_COLOR_BACK)
> - ToolbarItem(AP_TOOLBAR_ID_COLOR_FORE)
> -
> ;-----------------------------------------------------------
>
> I do not know if these changes were supposed to be applied and were
> part of a
> redesign or are actually a mistake.

These changes were part of a redesign. Here are the relevant threads:

http://www.abisource.com/mailinglists/abiword-dev/2006/Sep/0029.html
http://www.abisource.com/mailinglists/abiword-dev/2006/Sep/0042.html

 
____________________________________________________________________________________
We won't tell. Get more on shows you hate to love
(and love to hate): Yahoo! TV's Guilty Pleasures list.
http://tv.yahoo.com/collections/265
Received on Thu Mar 29 18:36:49 2007