Re: dom - r23445 - abiword/trunk/src/af/xap/xp

On Wed, Apr 9, 2008 at 6:16 PM, <cvs@abisource.com> wrote:
>
> Author: dom
> Date: 2008-04-10 00:16:24 +0200 (Thu, 10 Apr 2008)
> New Revision: 23445
>
> Modified:
> abiword/trunk/src/af/xap/xp/xap_Strings.cpp
> Log:
> Refactor getValueUTF8(), in a blind attempt to resolve #11533. Sum1's DrWatson backtrace of 2.6.2 is @ http://pastebin.ca/978855

Thanks for fixing this bug, Dom. I added the pastebin backtrace to
Bug 11509 for archival purposes.

>
> 1) Return if toStranslate is null.

This is the real cause of the crash. Some of the localized normal.awt
templates have invalid or unknown lang attributes that cause the NULL
pointer to be passed in. I fixed one template in r23446 and will look
for other problematic ones.

> 2) Route the UTF8 code through the general-purpose code
> 3) Don't throw exceptions
>
> Sum1: if this doesn't fix the problem for you, it would be useful to know what version of glib you're using and what the stringset's m_encoding is
>
Received on Thu Apr 10 03:26:45 2008