Re: customizable toolbars gone, and the option too [patch]

From: Ryan Pavlik <abiryan_at_ryand.net>
Date: Tue Jul 22 2008 - 20:44:52 CEST

J.M. Maurer wrote:
> On Tue, 2008-07-22 at 19:40 +0200, Benno Schulenberg wrote:
>
>> J.M. Maurer wrote:
>>
>>> On Sun, 2008-07-20 at 23:06 +0200, Benno Schulenberg wrote:
>>>
>>>> http://www.abiword.org/mailinglists/abiword-user/2008/Jan/0033.html
>>>>
>>>> From above message I understand that customizable toolbars no
>>>> longer work in 2.6 and above. But in the Preferences dialog
>>>> there still is an option called "Allow Custom Toolbars".
>>>> Shouldn't this option be removed?
>>>>
>>> If we don't allow it anymore, then yes: rip it out! :)
>>>
>> Okay. Attached patch removes the option and some of the mechanics.
>> There are more things that can be removed, but of some I'm unsure
>> whether they aren't needed for the normal construction of toolbars,
>> so I've been conservative in the cutting.
>>
>> Do all developers agree that this option should go? And that all of
>> the mechanisms that implement it can go too?
>>
>
> Patch looks good to me after reviewing it. Anyone against committing it?
>
> Marc
>
>
>
I'm pretty sure we still want the drop target section that refers to
EMBEDDED_PLATFORM_HILDON.

Ryan

-- 
Ryan Pavlik
www.cleardefinition.com
#282  +  (442) -  [X]
A programmer started to cuss
Because getting to sleep was a fuss
As he lay there in bed
Looping 'round in his head
was: while(!asleep()) sheep++;
Received on Tue Jul 22 20:45:57 2008

This archive was generated by hypermail 2.1.8 : Tue Jul 22 2008 - 20:45:57 CEST