Re: customizable toolbars gone, and the option too [patch]

> >> Okay. Attached patch removes the option and some of the mechanics.
> >> There are more things that can be removed, but of some I'm unsure
> >> whether they aren't needed for the normal construction of toolbars,
> >> so I've been conservative in the cutting.
> >>
> >> Do all developers agree that this option should go? And that all of
> >> the mechanisms that implement it can go too?
> >>
> >
> > Patch looks good to me after reviewing it. Anyone against committing it?
> >
> > Marc
> >
> >
> >
> I'm pretty sure we still want the drop target section that refers to
> EMBEDDED_PLATFORM_HILDON.

Are you sure? It wasn't before:

#if defined(EMBEDDED_TARGET) && EMBEDDED_TARGET ==
EMBEDDED_TARGET_HILDON
#else
snip
#endif

Note the empty if block!

  Marc
Received on Tue Jul 22 22:19:52 2008