Re: rp - r24212 - in abiword/branches/ABI-2-6-0-STABLE/src/pkg/win/setup/NSISv2: . lang plugins

sum1abi@gmail.com wrote:
> On Tue, Jun 10, 2008 at 12:50 AM, <cvs@abisource.com> wrote:
>
>> Author: rp
>> Date: 2008-06-10 06:50:39 +0200 (Tue, 10 Jun 2008)
>> New Revision: 24212
>>
>>
>
> [cut]
>
>
>> +Section "$(TITLE_section_impexpplugins_applix)" section_impexpplugins_applix
>> + SectionIn 2 4 ${DLSECT} ; Full w/ assoc, Full, Full w/ downloads
>> + SetOutPath $INSTDIR\plugins
>> + File "..\plugins\abiapplix.dll"
>> +SectionEnd
>> +
>>
>
> [cut]
>
>
>> +
>> + SetOutPath $INSTDIR\${PRODUCT}\plugins
>> + File "..\plugins\AbiMathView.dll"
>> +SectionEnd
>> +
>>
>
> [cut]
>
>
>> +;; freetranslation
>> +Section "$(TITLE_section_toolsplugins_freetranslation)" section_toolsplugins_freetranslation
>> + SectionIn 2 4 ${DLSECT} ; Typical, Full w/ assoc, Full, Full w/ downloads
>> + SetOutPath $INSTDIR\plugins
>> + File "..\plugins\Abifreetranslation.dll"
>> +SectionEnd
>>
>
> It looks like there are three different capitalization methods used
> for the DLL file names. Is that on purpose?
>
>
Somewhat - There actually should have only been 2 - the StudlyCaps which
is how the old installer did it, and the all lowercase which let me
create the second plugin installer file with simple
paste-search-replace. If it seems to work well in all types, I'd
suggest changing it all to the all lowercase, since it makes maintenance
easier. (My only concern is whether it works when using NSIS from *nix,
which might be case-sensitive unlike on Windows. We build
StudlyCaps-named files.)

-- 
Ryan Pavlik
www.cleardefinition.com
#282  +  (442) -  [X]
A programmer started to cuss
Because getting to sleep was a fuss
As he lay there in bed
Looping 'round in his head
was: while(!asleep()) sheep++;