Re: Fwd: Smart quotes patch

Bobby Weinmann wrote:
> Here is my second attempt at a patch. I have done some preliminary
> tests and it seems to work for English. The new thing is that UNDO
> WORKS! (at least for me)

Thanks for working on this; unfortunately the undo/redo seems to be
still broken -- try the following:

1. Type: This' a test.
2. Undo 3 times,
3. Redo 1 time: assert at px_ChangeHistory.cpp:138 (2x)

After that, it is not possible to do Redo again, and I am left with

This'

> 1) A GUI to set quote characters (I believe the rules will work for
> most languages, only the characters would need to change)

As I said before, this really should JustWork without any GUI -- we have
all the input that is need to decide what quotes to use, just need a
mechanism to translate sqQUOTEls, sqQUOTErs, sqQUOTEld, and sqQUOTErd to
the appropriate character based on the current language setting
(obtainable with fl_BlockLayout::getProperty()) before calling
cmdCharInsert().

> 2) An easy way to add an apostrophe at the beginning of a word ('Tis
> or 'em) - perhaps you could use the backtick?

Probably not the backtick unmodified, but perhaps something like
Ctrl+backtick, although that might become problematic with different kbd
layouts.

Tomas
Received on Wed Mar 12 23:03:02 2008