Re: Fwd: Smart quotes patch - committed.

Committed! Excellent work Bobby. works like a charm with AbiCollab
including undo/redo. Thank you very much. we've wanted to get this
feature right for a long time.

It may be worth backporting this to 2.6.

There are a few extra features improvements worth discussing though.

1. Implement Tomas's suggestion to allow the curly quote to be translated.
2. The feature has it's own panel in the Unix options dialog. It looks
pretty lonely up there.

Does it make sense to move the check box to another, pre-existing panel?

Anyway, congratulations once again. None of us has been able to get
this to work.

Cheers

Martin

--------------------------------------------
Thanks for the catch. I forgot to turn off smart quote replacement in
cmdRedo() as well as cmdUndo. Your test case works now. Please let
me know if you find any other similar problems.

I zipped the patch this time to make it a little smaller.

Bobby

On Wed, Mar 12, 2008 at 6:02 PM, Tomas Frydrych <tf@o-hand.com> wrote:
>
> Bobby Weinmann wrote:
> > Here is my second attempt at a patch. I have done some preliminary
> > tests and it seems to work for English. The new thing is that UNDO
> > WORKS! (at least for me)
>
> Thanks for working on this; unfortunately the undo/redo seems to be
> still broken -- try the following:
>
> 1. Type: This' a test.
> 2. Undo 3 times,
> 3. Redo 1 time: assert at px_ChangeHistory.cpp:138 (2x)
>
> After that, it is not possible to do Redo again, and I am left with
>
> This'
>
>
> > 1) A GUI to set quote characters (I believe the rules will work for
> > most languages, only the characters would need to change)
>
> As I said before, this really should JustWork without any GUI -- we have
> all the input that is need to decide what quotes to use, just need a
> mechanism to translate sqQUOTEls, sqQUOTErs, sqQUOTEld, and sqQUOTErd to
> the appropriate character based on the current language setting
> (obtainable with fl_BlockLayout::getProperty()) before calling
> cmdCharInsert().
>
>
> > 2) An easy way to add an apostrophe at the beginning of a word ('Tis
> > or 'em) - perhaps you could use the backtick?
>
> Probably not the backtick unmodified, but perhaps something like
> Ctrl+backtick, although that might become problematic with different kbd
> layouts.
>
> Tomas
>
>
Received on Sun Mar 16 03:40:45 2008