Re: About merging the AbiWord Unicode branch

Ola,

I've made an attempt at merging the branch into trunk to see how it
goes, but now I run into 150 compiler errors. Ick :)

One of the issues for example, is that
xap_Win32DialogHelper::getControlText() requires an LPSTR for the
buffer. This while the ported dialogs are passing in a unicode string
(LPTSTR).

If I change the LPSTR argument to getControlText into LPTSTR, then all
the non-ported dialogs break.

Any insights in this issue? How did you get this to compile in the first
place? :)

Cheers
  Marc

On Sat, 2009-11-21 at 21:07 +0530, Kathiravelu Pradeeban wrote:
> On Sat, Nov 21, 2009 at 8:13 PM, J.M. Maurer <uwog@uwog.net> wrote:
> >
> > On Sat, 2009-11-21 at 20:05 +0530, Kathiravelu Pradeeban wrote:
> > > Hi Marc,
> > > I had some dialogs port in incomplete stage after the pencils down
> > > date of GSoC, where I was able to track some bugs down with the Arabic
> > > testing at the final weeks of the Summer of Codes. I have listed the
> > > status of the port
> > > http://kkpradeeban.blogspot.com/search/label/AbiWord in my blog.
> >
> > What would "incomplete" mean? Will they suck as much as before, or are
> > they "totaly broken" now?
>
> I was able to fix and commit most of the broken stuff during the last
> weeks of August.
> Mostly the left incomplete dialogs are fine as ANSI as they were before.
>
> I will discuss the issues that better be addressed before the merge.
>
>
> >
> > > I have committed revision 28092 on Sep 1 to
> > > http://svn.abisource.com/abiword/branches/gsoc2009unicode/ as my
> > > latest commit, after the SoC timeframe. And my idea was to complete
> > > the porting asap and get involved in the merge.
> > >
> > > As our University reopened on September, I got busy with the final
> > > year projects and academics. I will be able to get involved again
> > > actively after the first week of February 2010, where we will have our
> > > first semester exams completed, if the time line of Abiword 3.0
> > > release permits.
> > >
> > > I am awaiting the possible merge soon, with no bugs introduced.
> >
> > Depending on how hard it will break things, I'll merge really soon!
> >
> Thanks.
> Pradeeban.
>
> > Cheers!
> > Marc
> >
> > > Thank you.
> > > Regards.
> > > Pradeeban.
> > >
> > > On Sat, Nov 21, 2009 at 7:39 PM, J.M. Maurer <uwog@uwog.net> wrote:
> > > >
> > > > Does anyone know what the current status of the Win32 Unicode branch
> > > is?
> > > > Is it complete? Is it buggy? Or is it good enough to merge into
> > > trunk?
> > > >
> > > > Cheers!
> > > > Marc
> > > >
> > >
> > >
> > >
> > > --
> > > Pradeeban.
> > > University of Moratuwa.
> > > [06CSE]
> > > http://kkpradeeban.blogspot.com/
> >
>
>
>
> --
> Pradeeban.
> University of Moratuwa.
> [06CSE]
> http://kkpradeeban.blogspot.com/
Received on Sun Nov 22 20:58:00 2009