Re: Help with Write Activity

>
>> #3913 Format popup should have dividers (http://dev.laptop.org/ticket/3913)
>
> Not 100% sure what the "Format Popup" means, but I think this is the
> combobox in the python toolbar. If it is, then this would be a trivial
> fix.

Ok.
Tentative patch:

[gonzalo@nautilus write]$ git diff toolbar.py
diff --git a/toolbar.py b/toolbar.py
index d15f110..db3945c 100644
--- a/toolbar.py
+++ b/toolbar.py
@@ -659,19 +659,25 @@ class FormatToolbar(gtk.Toolbar):
             ['Heading 2',_('Heading 2')],
             ['Heading 3',_('Heading 3')],
             ['Heading 4',_('Heading 4')],
+ [None, None],
             ['Bullet List',_('Bullet List')],
             ['Dashed List',_('Dashed List')],
             ['Numbered List',_('Numbered List')],
             ['Lower Case List',_('Lower Case List')],
             ['Upper Case List',_('Upper Case List')],
+ [None, None],
             ['Block Text',_('Block Text')],
             ['Normal',_('Normal')],
             ['Plain Text',_('Plain Text')]]
         self._style_changed_id = self._style_combo.connect('changed',
self._style_changed_cb)
         for i, s in enumerate(self._styles):
- self._style_combo.append_item(i, s[1], None)
- if s[0] == 'Normal':
- self._style_combo.set_active(i)
+ if s[1] != None:
+ self._style_combo.append_item(i, s[1], None)
+ if s[0] == 'Normal':
+ self._style_combo.set_active(i)
+ else:
+ self._style_combo.append_separator()
+
         tool_item = ToolComboBox(self._style_combo)
         self.insert(tool_item, -1);
         tool_item.show()

I think wold be better if the Normal style is at the top. But i can
change it in another patch if you agree.

>
>> #3220 Write's 'view' tab size control demands excessive horizontal
>> scrolling (http://dev.laptop.org/ticket/3220)
>
> We do have a sortof working "web layout" these days (like requested in
> the comment by ssb22), but I'd advise against switching to it without a
> lot of testing.
>

>> #3615 In Write, Alt-C doesn't work while the 'Insert Image' pulldown
>> is present. (http://dev.laptop.org/ticket/3615)
>
> What is ALT-C even supposed to do? (I don't have an OLPC environment
> running at the moment to test).
>

I think was close the activity, but now is Ctrl-Q.
Anyway, the insert image dialog (the ObjectChooser) is modal, and must
be closed
before closing the activity. I think it is not a bug.

Gonzalo
Received on Thu Nov 25 19:47:37 2010