[Fwd: modified documents issue in abiword trunk]

Should have cced the list, sorry

attached mail follows:

Hi Martin,

Since some times, saving a document from abiword trunk does not anymore
remove the dirty property of the document. I could track the issue to
revision 27751 (lognpt branch) were you modified the
PD_Document::_setClean() method:

@@ -1177,8 +1177,6 @@
 
 void PD_Document::_setClean(void)
 {
- m_pPieceTable->setClean();
- m_pPieceTable->getFragments().cleanFrags();
         _setForceDirty(false);
 }

Since isDirty() checks if the pt is clean, it always return true if the
document has been modified, even if the file has been saved. Should
isDirty() be modified to not check the piece table dirtiness anymore?

Cheers,
Jean
Received on Mon Oct 25 14:59:37 2010